Make TerminalType a parameter and default to xterm #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #6.
I've made TerminalType an optional parameter, which defaults to 'xterm', so that it can be set to whatever the user needs.
Ideally, I'd like to autocomplete a list of valid terminal types... but I wasn't able to find a way to enumerate them. I get the feeling it's the sort of thing that if you're setting it to something other than the default that you probably know what to set it to.
Eventually it'd pay to add a switch to preserve the existing terminal type, it's just a matter of making this user friendly with the parameter sets.