docs-only change #16
Closed
docs-only change #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a pull request doesn't touch the bpf/ directory, we don't need to check that the datapath compiles for every commit. Signed-off-by: Paul Chaignon <paul@cilium.io>
The coccinelle and build checks are unnecessary when files under bpf/ and contrib/coccinelle/ are untouched. We still need to run checkpatch because it actually verifies all commits and not only code touching bpf/. Signed-off-by: Paul Chaignon <paul@cilium.io>
We don't need to run documentation tests if the documentation is untouched. Signed-off-by: Paul Chaignon <paul@cilium.io>
We don't need to run the smoke tests if only Documentation/ or test/ are touched. We therefore skip them in such case. Obviously, we could extend this beyond these two directories, but the goal here is to keep the list simple while catching the most common cases. Signed-off-by: Paul Chaignon <paul@cilium.io>
We don't need to run the ci-xxx end-to-end tests if only Documentation/ or test/ are touched. We therefore skip them in case of the trigger phrase 'test-me-please'. If these tests are explicitly requested via the 'ci-xxx' trigger phrase, we run them. Obviously, we could extend this beyond these two directories, but the goal here is to keep the list simple while catching the most common cases. Signed-off-by: Paul Chaignon <paul@cilium.io>
When updating a pull request, workflows associated with the previous version continue to run. A way to prevent that and cancel outdated workflows is to use concurrency groups. This commit handles workflows triggered by pull requests and pushes. We define each concurrency group such that they are unique to the pull request (via PR number) if triggered by event pull_request or to the commit (via SHA) if triggered by event push. Signed-off-by: Paul Chaignon <paul@cilium.io>
When updating a pull request, workflows associated with the previous version continue to run. A way to prevent that and cancel outdated workflows is to use concurrency groups. This commit fixes workflows running on a schedule or on PR comment. We define each concurrency group such that they are unique to the pull request (via PR URL) if triggered by event issue_comment. For each workflow, there's a single concurrency group for all scheduled runs. That assumes the timeout of scheduled workflows is always shorter than the duration between two runs. Signed-off-by: Paul Chaignon <paul@cilium.io>
Signed-off-by: Paul Chaignon <paul@cilium.io>
Signed-off-by: Paul Chaignon <paul@cilium.io>
|
test-me-please GKE, EKS, AKS, and multicluster tests are not shown because they were skipped. See for example https://github.com/pchaigno/cilium/actions/runs/851362179. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image building fails because I don't have the right credentials.
Docs GHA should run, but BPF build, smoke tests, and Kind test should be skipped.