bug fix: avoid 'bad block' after executing extrRwd transaction

possible reason: when one block with extrRwd transaction inserted, the same block could be inserted again because the synchronize-mechanism. In theory this should not happen, but it happens. Then the rewardBalance could be wrongly calculated because lack of history-data in OutsideOfStorage reward, and 'bad block' comes. fix: add 5('OBR_SIZE' in code) history data cache for OutsideOfStorage reward, and this can support 4(OBR_SIZE-1) blocks rollback; basically this should reduce the 'bad block' much Test cases & expected results: 1, synchronize pchain from block 0 till the latest with no error 2, after new block with new extrRwd transaction inserted/reinserted, the 'bad block' should not appear, at least the frequency should be very very low
pchain-org · Jan 14, 2021 · e719c81 · e719c81
1 parent ec48c7c
commit e719c81
Show file tree

Hide file tree

Showing 10 changed files with 193 additions and 73 deletions.
diff --git a/vendor/github.com/ethereum/go-ethereum/common/out_of_storage.go b/vendor/github.com/ethereum/go-ethereum/common/out_of_storage.go
diff --git a/vendor/github.com/ethereum/go-ethereum/consensus/pdbft/engine.go b/vendor/github.com/ethereum/go-ethereum/consensus/pdbft/engine.go
diff --git a/vendor/github.com/ethereum/go-ethereum/consensus/pdbft/epoch/epoch.go b/vendor/github.com/ethereum/go-ethereum/consensus/pdbft/epoch/epoch.go
diff --git a/vendor/github.com/ethereum/go-ethereum/core/blockchain.go b/vendor/github.com/ethereum/go-ethereum/core/blockchain.go
diff --git a/vendor/github.com/ethereum/go-ethereum/core/rawdb/accessors_chain.go b/vendor/github.com/ethereum/go-ethereum/core/rawdb/accessors_chain.go
diff --git a/vendor/github.com/ethereum/go-ethereum/core/rawdb/schema.go b/vendor/github.com/ethereum/go-ethereum/core/rawdb/schema.go
diff --git a/vendor/github.com/ethereum/go-ethereum/core/state/statedb_reward.go b/vendor/github.com/ethereum/go-ethereum/core/state/statedb_reward.go
diff --git a/vendor/github.com/ethereum/go-ethereum/internal/ethapi/api.go b/vendor/github.com/ethereum/go-ethereum/internal/ethapi/api.go
diff --git a/vendor/github.com/ethereum/go-ethereum/internal/ethapi/delegate_api.go b/vendor/github.com/ethereum/go-ethereum/internal/ethapi/delegate_api.go