Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various string crashes #27

Closed
pcmacdon opened this issue Oct 22, 2020 · 1 comment
Closed

Various string crashes #27

pcmacdon opened this issue Oct 22, 2020 · 1 comment

Comments

@pcmacdon
Copy link
Owner

It looks like jsish is failing to check/enforce some of the basic string limits, and crashes instead of erroring out.

var s = 'abcdefghijklmnopqrstuvwxyz';
try { s.repeat(9999999);
} catch(e) { puts('repeat fail', e); }
while (true)
   s += s;
pcmacdon pushed a commit that referenced this issue Oct 22, 2020
FossilOrigin-Name: 2d9aad3a40a18110212c0841a43475126ce8bbfe9df92f5318fe0e401449806a
@pcmacdon
Copy link
Owner Author

pcmacdon commented Oct 22, 2020

Should be fixed no.

DString does not error out when limits are exceeded, by design. It truncates to the max and prints an error. This should mean incorrect results at the boundary, but not crashes.

There could be more, so am leaving this open for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant