Fix PCMan is preventing shutdown #29 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holishing
reviewed
Jan 9, 2018
Lite/MainFrm.cpp
Outdated
| @@ -79,6 +79,7 @@ BEGIN_MESSAGE_MAP(CMainFrame, CFrameWnd) | |||
| ON_WM_INITMENUPOPUP() | |||
| ON_WM_CLOSE() | |||
| ON_WM_ACTIVATE() | |||
| ON_WM_QUERYENDSESSION() | |||
There was a problem hiding this comment.
I think TAB is better than 4 space here.. (follow origin coding style)
holishing
reviewed
Jan 9, 2018
Lite/MainFrm.cpp
Outdated
| @@ -829,6 +830,11 @@ void CMainFrame::OnActivate(UINT nState, CWnd* pWndOther, BOOL bMinimized) | |||
| #endif | |||
| } | |||
|
|
|||
| BOOL CMainFrame::OnQueryEndSession() | |||
| { | |||
| return 1; | |||
There was a problem hiding this comment.
I think TAB is better than 4 space here.. (follow origin coding style)
holishing
reviewed
Jan 9, 2018
Lite/MainFrm.h
Outdated
| @@ -181,6 +181,7 @@ class CMainFrame : public CFrameWnd | |||
| afx_msg void OnSize(UINT nType, int cx, int cy); | |||
| afx_msg void OnClose(); | |||
| afx_msg void OnActivate(UINT nState, CWnd* pWndOther, BOOL bMinimized); | |||
| afx_msg BOOL OnQueryEndSession(); | |||
There was a problem hiding this comment.
I think TAB is better than 4 space here.. (follow origin coding style)
|
加入.editorconfig，VS2017 tab預設好像是4，那就不會有問題 |
VS2017 supports this natively.
|
改變想法，用tab比較好，tab的長度我是直接照linux kernel style用8 (github上的預設也是8) |
|
我也比較喜歡 TAB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
經測試，加入WM_QUERYENDSESSION處理就有效了