Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal windows cannot be dismissed on smaller screens #71

Closed
npch opened this issue Mar 6, 2013 · 5 comments
Closed

Modal windows cannot be dismissed on smaller screens #71

npch opened this issue Mar 6, 2013 · 5 comments

Comments

@npch
Copy link

npch commented Mar 6, 2013

When using the site on smaller screen resolutions (in this case 1366x768) modal windows (such as the first Alert dialog - pictured below) cannot be dismissed as the button at the bottom of the dialog is not visible, and browser scroll bars do not work (in this case for Google Chrome 24.0.1312.57), and the red Mac OS X style button in the top left of the dialog does not work either.

The ability to either dimiss the modal window using the red button, or use the browser scroll bars should be enabled when such a window appears.

CapturFiles_24

@pcottle
Copy link
Owner

pcottle commented Mar 6, 2013

Hey Neil,

Sorry to hear this -- I developed the site to work on half width of my
MacBook Air screen but I didn't intend for screens to be so short.

The quick fix is that you can use the arrow keys to proceed through a
dialog, so try tapping left / right / escape.

The solution I'll aim for is to enable scrolling on these dialogs, but
that's something that will happen over the weekend :/

On Wednesday, March 6, 2013, Neil Chue Hong wrote:

When using the site on smaller screen resolutions (in this case 1366x768)
modal windows (such as the first Alert dialog - pictured below) cannot be
dismissed as the button at the bottom of the dialog is not visible, and
browser scroll bars do not work (in this case for Google Chrome
24.0.1312.57), and the red Mac OS X style button in the top left of the
dialog does not work either.

The ability to either dimiss the modal window using the red button, or use
the browser scroll bars should be enabled when such a window appears.

[image: CapturFiles_24]https://f.cloud.github.com/assets/1507151/227720/da1a4eec-866a-11e2-9807-326b59aac90c.png


Reply to this email directly or view it on GitHubhttps://github.com//issues/71
.

-Sent from Gmail Mobile

@npch
Copy link
Author

npch commented Mar 6, 2013

I confirm that the arrow keys work as a quick fix - thanks!

I'll leave the issue open until scrolling is enabled.

(great resource by the way - thanks for creating it!)

pcottle added a commit that referenced this issue Mar 7, 2013
@pcottle
Copy link
Owner

pcottle commented Mar 7, 2013

Fixed! Thanks for dropping by, should have a nice bottom margin now

@pcottle pcottle closed this as completed Mar 7, 2013
@npch
Copy link
Author

npch commented Mar 7, 2013

I confirm that this fix works for me - it corrects the issue by enabling scrolling of the whole browser frame.

Thanks!

@pcottle
Copy link
Owner

pcottle commented Mar 7, 2013

Cool -- Added you to the README, sorry I forget sometimes :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants