Resolves #1139: can use a direct permalink to a specific level #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for xenodochial-hugle-b9ec84 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pomeh
commented
Apr 24, 2024
| @@ -237,6 +237,10 @@ var initDemo = function(sandbox) { | |||
| 'levels' | |||
| ]; | |||
| commands = commands.join(';#').split('#'); // hax | |||
| } else if (params.hasOwnProperty('level')) { | |||
| commands = [ | |||
| 'level ' + unescape(params.level), | |||
There was a problem hiding this comment.
I've not implemented checks on the params.level format/value here.
I'm not really confortable with this idea, as an app must always validate input args/user values before using them, but I've not implemented it myself to stick to the coding style for others parameters, where there is no check either.
There was a problem hiding this comment.
no worries, we do some validation when we run the command and provide an error response :)
|
Looks great! I also think this will work if you provide both a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the issue #1139 I just created, about permalink to levels.
I did not add unit tests as I didn't find anywhere query arguments are tested. But I've manually tested my changes through Gitpod (which is simply amazing !).
I also was thinking about a "share level" feature, but:
Feel free to let me know what you think about all this.