Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow yaml based configuration to ignore certain models. #1

Merged
merged 1 commit into from
Aug 20, 2017
Merged

Allow yaml based configuration to ignore certain models. #1

merged 1 commit into from
Aug 20, 2017

Conversation

vraravam
Copy link

@pcreux - I had this working at a different project a long time ago when I was conversing with you in 2014. Somehow that got lost, so I have recreated the code again. Its pretty simple, please review and publish a new version of the gem asap?

@pcreux
Copy link
Owner

pcreux commented May 18, 2017

This is awesome! Thank you!

@vraravam
Copy link
Author

You're welcome! Happy to contribute back to an awesome gem that you had created.

@vraravam
Copy link
Author

@pcreux - can you please merge this into your master branch?

@pcreux
Copy link
Owner

pcreux commented May 19, 2017 via email

@vraravam
Copy link
Author

vraravam commented Jun 9, 2017

@pcreux - ping

@pcreux
Copy link
Owner

pcreux commented Jun 28, 2017

Hey @vraravam, I'm not finding the time to work on getting the tests to pass. In the meantime, feel free to publish your version to rubygems.org with a different name.

@vraravam
Copy link
Author

@pcreux - I am not a fan of a forked gem with a different name. So, i'll wait for your tasks to get done. I can (and am already) using the GH repo url in my Gemfile to get my version in my projects.

@vraravam
Copy link
Author

@pcreux - any updates on this ?

@pcreux
Copy link
Owner

pcreux commented Aug 20, 2017

@vraravam I just got the tests to pass on my machine and Travis-CI (see #2). I've rebased your branch against it and your tests passed!

Thank you for your contribution. I merging this one in and releasing a new minor version.

@pcreux pcreux merged commit 1dea696 into pcreux:master Aug 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants