feat(api): Made supported subs configurable

pct-org · Oct 12, 2020 · f3ffc19 · f3ffc19
1 parent c32ccfb
commit f3ffc19
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/apps/api/src/shared/config/config.service.ts b/apps/api/src/shared/config/config.service.ts
@@ -18,6 +18,7 @@ export class ConfigService {
   public static readonly DOWNLOAD_LOCATION: string = 'DOWNLOAD_LOCATION'
   public static readonly OPENSUBTITLES_USERNAME: string = 'OPENSUBTITLES_USERNAME'
   public static readonly OPENSUBTITLES_PASSWORD: string = 'OPENSUBTITLES_PASSWORD'
+  public static readonly SUBTITLES_LANGUAGES: string = 'SUBTITLES_LANGUAGES'
   public static readonly MAX_CONCURRENT_DOWNLOADS: string = 'MAX_CONCURRENT_DOWNLOADS'
   public static readonly TRAKT_KEY: string = 'TRAKT_KEY'
 
@@ -103,7 +104,11 @@ export class ConfigService {
 
       [ConfigService.OPENSUBTITLES_USERNAME]: Joi.string(),
 
-      [ConfigService.OPENSUBTITLES_PASSWORD]: Joi.string()
+      [ConfigService.OPENSUBTITLES_PASSWORD]: Joi.string(),
+
+      [ConfigService.SUBTITLES_LANGUAGES]: Joi.string()
+        .default('en'),
+
       [ConfigService.MAX_CONCURRENT_DOWNLOADS]: Joi.number()
         .default(1),
     })

diff --git a/apps/api/src/shared/subtitles/subtitles.service.ts b/apps/api/src/shared/subtitles/subtitles.service.ts
@@ -18,20 +18,15 @@ export class SubtitlesService {
 
   private readonly enabled: boolean = true
 
-  /**
-   * TODO:: Get from ENV
-   */
-  private readonly supportedLanguages = [
-    'en',
-    'nl'
-  ]
+  private readonly supportedLanguages
 
   constructor(
     private readonly httpService: HttpService,
     private readonly configService: ConfigService
   ) {
     const username = this.configService.get(ConfigService.OPENSUBTITLES_USERNAME)
     const password = this.configService.get(ConfigService.OPENSUBTITLES_PASSWORD)
+    this.supportedLanguages = this.configService.get(ConfigService.SUBTITLES_LANGUAGES)
 
     if (username && password) {
       this.client = new OpenSubtitles({
@@ -52,7 +47,7 @@ export class SubtitlesService {
    * @param {TorrentFile} torrent - The torrent to search subtitles for.
    * @param {boolean} retry - Are we allowed to retry or not.
    */
-  public async searchForSubtitles(download: Model<Download>, torrent: TorrentFile, retry = true) {
+  public async searchForSubtitles(download: Model<Download>, torrent: TorrentFile, retry = true): Promise<void> {
     // Only search for subtitles when it's enabled
     if (!this.enabled) {
       return