Fix for best parameters not updating when MCMC finds a better fit than least-squares #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating fork
Fix MCMC not updating best parameters when finding a better fit than least-squares
|
Oh, wow! This is very obscure, good catch, thanks! |
|
Hi @rychallener , I had forgotten to upload this fix to pypi, the code it's up to date there now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue is that the least-squares bestp array is currently overwriting the shared-memory array. Since the least-squares bestp array is a normal numpy array, the shared-memory aspect is lost and bestp can't be properly updated by the subprocess chains. Solution is to copy only the values within the least-squares bestp array.