bz18517: Don't failed_soft() if we notice the thread was already gone. #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -393,14 +393,29 @@ class SubprocessManager(object): | |||
| def _on_thread_quit(self, thread): | |||
| """Handle our thread exiting.""" | |||
|
|
|||
| # Igoner this call if it was queued from while we were in the middle | |||
| # Igonre this call if it was queued from while we were in the middle | |||
There was a problem hiding this comment.
Closer! Should be "Ignore"
|
Other than that, looks good. |
We could lose the race by the time we come here and as a result self.thread is already None. If it is then it is harmless and so just return.
paulswartz
added a commit
that referenced
this pull request
Dec 2, 2011
bz18517: Don't failed_soft() if we notice the thread was already gone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could lose the race by the time we come here and as a result
self.thread is already None. If it is then it is harmless and so
just return.
I think this basically should do the trick with minimal invasive changes.