Hotfix/http errors #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Because we're no longer raising errors, should the test cases be asserting that there are no errors? I'm not sure one way or the other. |
|
I don't think we need to do that; if there are propagated errors, they'll show up in the testing anyway. |
|
The errors aren't propogated, but clearly something is broken w/ Vimeo and the test cases are still passing. However, I don't believe it's an issue we need to address with this hotfix branch; we can handle it in develop and release 0.6 with working Vimeo support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What we need is to have better error handling in vidscraper; this will solve the issue for any api malfunctions in the future, and still provide access to the errors for debugging.
Travis run: http://travis-ci.org/pculture/vidscraper/builds/1436414