Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build error #32

Closed
tinywombat765 opened this issue Jan 4, 2017 · 2 comments
Closed

Build error #32

tinywombat765 opened this issue Jan 4, 2017 · 2 comments

Comments

@tinywombat765
Copy link

When I try to build the library I get
g++: error: /home/zethra/rust-media/target/debug/build/rust-media-4f16ffe1a06b74e6/out/../../libwebm-sys-8601c49ada690de1/out: No such file or directory
@est31
Copy link
Contributor

est31 commented Jan 30, 2017

I think #33 fixes this.

@est31
Copy link
Contributor

est31 commented Jan 30, 2017

Hmm, there is still a race condition. I think I'll file a PR for it.

est31 added a commit to est31/rust-media that referenced this issue Jan 31, 2017
@est31
Fix race condition on fresh clone
b33b3f1 
Previously, with a fresh clone you could get an error that
mkvparse.hpp couldn't be found. This was because mkvparse.hpp
is inside the libwebm-sys crate which is only used as dependency.

However, as cargo handles build.rs dependencies separately from
the crate's dependencies, libwebm-sys sometimes wasn't copied/downloaded
into the target/ directory yet when build.rs ran.
By adding libwebm-sys to the build-dependencies of this crate we
ensure its always inside target/.

Fixes pcwalton#32 (together with commit 51dd086)
@est31 est31 mentioned this issue Jan 31, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tinywombat765 @est31