Fix broken sys_alsa_putmidibyte() in order to make midiout work on Linux. #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a long-standing bug with midiout on ALSA, which would just output malformed 1-byte "sysex" messages for each byte that goes into midiout. The bug affects all Linux versions of Pd, in all flavors. For a test witness, run the cyclone/seq-help.pd patch and hook it up to kmidimon or qmidiroute to see the MIDI output. The new implementation proposed here does the necessary buffering and parsing using the appropriate ALSA routines to emit proper MIDI messages. It also works fine with system realtime and exclusive messages.