Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Organizations of a user #58

Closed
shreyas1599 opened this issue Apr 11, 2020 · 7 comments · Fixed by #72
Closed

Add Organizations of a user #58

shreyas1599 opened this issue Apr 11, 2020 · 7 comments · Fixed by #72
Labels
enhancement New feature or request

Comments

@shreyas1599
Copy link
Contributor

Currently, the organizations a user belongs to is not displayed. Also, if a repo belongs to an organization instead of an individual as is the case with this repo, the link of the organization won't work.

So we need an organization screen and on the profile page, the list of organizations the user is a part of. Where do you think we could place it? (It'd just be a row(s) of profile pictures)

image

Below the yellow line or above the contributions graph or anywhere else?

@pd4d10 pd4d10 added the enhancement New feature or request label Apr 12, 2020
@pd4d10
Copy link
Owner

pd4d10 commented Apr 12, 2020

I'm not sure. Seems both would be OK?

@shreyas1599
Copy link
Contributor Author

shreyas1599 commented Apr 12, 2020

@pd4d10 I need some help. I'm trying to add the organization connection in gh_user.graphql. Under repositoryOwner and inside ... on User is where I'm trying to place it. But for some reason it affects the results of ... on Organization in gh_user.dart. Am I doing anything wrong?

@pd4d10
Copy link
Owner

pd4d10 commented Apr 13, 2020

It seems an issue of the artemis lib: comigor/artemis#18

I tried to upgrade its version before but got another problem: comigor/artemis#63 (comment)

@shreyas1599
Copy link
Contributor Author

Alright. Also in the org_repo
screen some organizations have to enable permission for us to be able to fetch details. For example, I'm able to view the Google organization but not the git touch organization (it is stuck on loading forever). Do you think if would be good to add a timeout option and tell display a pop-up telling the user about this? But as far as I know you are already displaying an error message if an error occurs. Still no error message pops up. Maybe because we should add a timeout feature?

@pd4d10
Copy link
Owner

pd4d10 commented Apr 13, 2020

I'm not sure if the permission you mentioned is related to this:

https://github.com/git-touch/git-touch/blob/805f065def16e008d65d5fc230eb1a212df93319/lib/screens/gh_org_repos.dart#L10-L15

We have changed it from GraphQL to RESTful API to avoid the access restriction.

@pd4d10
Copy link
Owner

pd4d10 commented Apr 13, 2020

. Maybe because we should add a timeout feature?

Agreed. We could have one.

@shreyas1599
Copy link
Contributor Author

I'm not sure if the permission you mentioned is related to this:

https://github.com/git-touch/git-touch/blob/805f065def16e008d65d5fc230eb1a212df93319/lib/screens/gh_org_repos.dart#L10-L15

We have changed it from GraphQL to RESTful API to avoid the access restriction.

Yeah, I saw this but for some reason it still doesn't load even though the organization is public( I'm talking about git-touch). Timeout sounds like a hacky fix for now. Doesn't point to the underlying problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants