Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support latest React version (17 and above) #36

Closed
wants to merge 1 commit into from

Conversation

HamdyD
Copy link

@HamdyD HamdyD commented May 23, 2022

What is the issue

svgr has a devDependencies for react set to version 17. It is not possible to use the package vite-plugin-svgr with the last version of react, which is the version 18.
It throws the following error :

Could not resolve dependency:
peer react@"17.0.2" from vite-plugin-svgr-component@1.0.0
node_modules/vite-plugin-svgr-component
dev vite-plugin-svgr-component@"1.0.0" from the root project

Proposed solution

This solution intend to specifically state the peerDependencies for react, and allow everyone to use this plugin with the latest version of React.

@HamdyD HamdyD changed the title feat: support react version 17 and above feat: support latest React version (17 and above) May 23, 2022
@HamdyD HamdyD closed this May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant