Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow 7.x and 8.x versions of svgr packages #81

Closed
wants to merge 1 commit into from
Closed

feat: allow 7.x and 8.x versions of svgr packages #81

wants to merge 1 commit into from

Conversation

fvsch
Copy link
Contributor

@fvsch fvsch commented Jul 24, 2023

Hello there. I'm using this plugin in a repository which also uses the latest version of @svgr/webpack, and ideally I'd like to use the same @svgr/core and @svgr/plugin-* packages for both Vite and Webpack.

SVGR 8.0.0 was released a couple months ago and has very limited breaking changes. I think it should be safe to allow this plugin to be used with both v7 and v8 of @svgr/core and @svgr/plugin-jsx packages. What do you think?

https://github.com/gregberge/svgr/releases/tag/v8.0.0

@pd4d10
Copy link
Owner

pd4d10 commented Sep 20, 2023

Thanks for the contribution!

Let's update it to v8 directly, see a64ff2c

@pd4d10 pd4d10 closed this Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants