Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot just put pdb.py in $PYTHONPATH to install (as mentioned in README) #376

Open
Maltimore opened this issue Mar 20, 2020 · 3 comments · May be fixed by #378
Open

Cannot just put pdb.py in $PYTHONPATH to install (as mentioned in README) #376

Maltimore opened this issue Mar 20, 2020 · 3 comments · May be fixed by #378

Comments

@Maltimore
Copy link

In the README it says that you can just put the relevant pdb.py file in a directory mentioned in the pythonpath in order to install pdbpp. This doesn't work because then fancycompleter isn't installed and you get an import error.

@blueyed
Copy link
Collaborator

blueyed commented Mar 20, 2020

Yeah, that's probably outdated / should get fixed/removed.

The plan is to make the fancycompleter dependency optional though, which mainly means to adopt/vendor its classes (ConfigurableClass, which should get revisited then also) / fix color imports.

I'd be happy to merge a PR fixing the readme for now, or might look into it myself later.

@Maltimore
Copy link
Author

Maltimore commented Mar 20, 2020

I'm happy to make a PR updating the README. Should the instruction be to

  • install fancycompleter with pip/conda
  • copy the pdb.py into somewhere under the $PYTHONPATH?

By the way the pdb.py is actually called pdbpp.py and needs to be renamed when copying, I can mention that also.

blueyed added a commit to blueyed/pdbpp that referenced this issue Mar 20, 2020
@blueyed blueyed linked a pull request Mar 20, 2020 that will close this issue
@blueyed
Copy link
Collaborator

blueyed commented Mar 20, 2020

@Maltimore
I've revisited it myself in #378 - please review.

I do not think copying pdbpp.py manually is a good idea - at least for a README. I'm often symlinking it myself etc (since editable installs are not really working with regard to the hijacking) for some repos/checkouts, but that is something more advanced.

And using pip for installation should take care of dependencies already.
Note however that pyrepl is optional (IIRC), but certainly improves the completion experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants