Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaling issue for 1D Advection data #46

Closed
apivich-h opened this issue Aug 18, 2023 · 4 comments
Closed

Scaling issue for 1D Advection data #46

apivich-h opened this issue Aug 18, 2023 · 4 comments

Comments

@apivich-h
Copy link

From Fig. 6 of the paper (in the Appendix):

image

Based on the closed form of the formula (Appendix D1), I feel the right-hand chart seems to have inconsistent scaling in time dimension compared to the PDE, i.e. the time value should be 2 times what the y-axis of the graph says, or beta should be double the value.

I also find a similar problem from the downloaded file from the url listed in data_download, where the dataset for the Advection dataset doesn't seem to be consistent with the Advection formula due to the similar scaling issue (based on just observing the array in the returned object).

Thanks in advance for your response.

@mtakamoto-D
Copy link
Collaborator

Thank you very much for your kind pointing out!
Actually it results from a very silly typo in the code generating code that has been fixed in the latest version.
The regenerated dataset will be released soon. We are also preparing for an update of arXiv paper with recalculated results on the new dataset..

@apivich-h
Copy link
Author

Hi, thanks for your quick response and clarification.

May I also ask further which other PDE datasets (if any) were affected by the typo, apart from Advection 1D that I mentioned?

@mtakamoto-D
Copy link
Collaborator

It is only for advection equation.
We are now reassessing all the data generation code. We update the code and data if we found any issues.

@kmario23
Copy link
Member

kmario23 commented Sep 5, 2023

Hi @apivich-h,
The code and datasets have been updated addressing the issue. The new datasets are already available on the PDEBENCH - DARUS repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants