Add SampleBuffer::clear()?

[torokati44]

I found myself in a situation where clearing an existing SampleBuffer would be really useful.
If I understand it right, that would be only a matter of setting n_written to 0.

However, I found no way of doing this other than assigning a newly created, empty buffer to it.

Is this something that could be added perhaps?

[torokati44]

And somewhat related: What's the point of storing n_written next to a Vec?
AFAIK Vec has this functionality built in.
That is: it has a separate capacity and len.

[pdeljanov]

Hi @torokati44,

Having a clear method is a good idea. I haven't spent much time considering use cases for SampleBuffer outside of just grabbing samples from AudioBuffers.

I've chosen not to resize the vector because it would likely involve extra zeroing operations, and/or extra allocations/deallocations. By managing the buffer myself I can avoid those.

That being said, it should really be a boxed slice of S instead of Vec<S> if the vector methods aren't being used.

[torokati44]

Having a clear method is a good idea.

Thanks for adding this to a milestone!

I haven't spent much time considering use cases for SampleBuffer outside of just grabbing samples from AudioBuffers.

This is how it came up:
torokati44/ruffle@c2ccacd
I hope the surrounding code can provide more context as to why.

I've chosen not to resize the vector because it would likely involve extra zeroing operations

Okay, I see, that makes sense. I only considered the allocation part, which would likely(?) not take place, but the zeroing almost certainly would, yeah.

[torokati44]

Fixed by 10e8a2d.
Thanks a lot!