Fix clippy warnings #144
Merged
Fix clippy warnings #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdeljanov
requested changes
Dec 14, 2022
This is done by allow() due to the testing of a bool returning function
This ignores clippy::uninlined_format_args
pdeljanov
reviewed
Jan 13, 2023
|
Thanks for fixing all of these! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes existing clippy warnings, with a lot of them triggered by test code.
I guess clippy wasn't run before to find these test warnings, and then the existing warnings were hidden for users like me using rust-analyzer