Handle incorrect channel mask in WAV files #180
Conversation
|
Hi @jesnor, I've considered this workaround before since I've seen a single file with this issue. I didn't implement it because it didn't seem common and also because the channel mapping will be very wrong if > 2 channels. Do you think we should limit this workaround if only Do you also happen to know if the WAV files were produced by a particular app or encoder? Thanks! |
|
The file that failed for me had 9 channels, created with Audacity I think. Interestingly a similar file with 8 channels had correct channel mask. Since VLC can play the file, I think the patch is reasonable. It's better to be able to decode something rather than nothing, although the channel mask might be weird. |
|
Found this documentation from Microsoft. Looks like We don't have a way to express un-positioned channels with Symphonia's current API, so your solution is valid for all channels then. Only other alternative would be to assume certain channel layouts for each number (i.e., 2.1 for 3, etc.). Just going to leave a couple small comments and then I'll merge the change once fixed. |
symphonia-format-wav/src/chunks.rs
Outdated
| let mut channel_mask = reader.read_u32()?; | ||
|
|
||
| // Graceful handling of "empty" channel mask value. Use the first n_channels channels. | ||
| if channel_mask == 0 { |
There was a problem hiding this comment.
If n_channels is also 0 then this should be executed because of the next comment.
|
Thanks! This is great! |
This PR contains a work around for some WAV files that have an incorrect channel mask value. For example VLC can still play them.