Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize CI #252

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Modernize CI #252

merged 3 commits into from
Feb 29, 2024

Conversation

a1phyr
Copy link
Contributor

@a1phyr a1phyr commented Jan 16, 2024

  • Update actions/checkout
  • Replace actions-rs/toolchain with manual install
  • Replace actions-rs/cargo by manual commands
  • Remove redundant "Test documentation" job

@pdeljanov
Copy link
Owner

Hi @a1phyr,

Thanks for this. I'm guessing the motivation was the archival of actions-rs?

Yesterday I cleaned up all the clippy warnings for the 0.5.4 release, would it be possible to have the CI run clippy and show any warnings in GitHub (though, preferably not block the PR)? It's probably the best time to introduce such a step.

@qarmin
Copy link

qarmin commented Feb 28, 2024

Rustup is now builtin into images, so there is no need to use external apps that duplicates rustup functionality

@a1phyr
Copy link
Contributor Author

a1phyr commented Feb 28, 2024

Would it be possible to have the CI run clippy and show any warnings in GitHub (though, preferably not block the PR)?

Unfortunately, GitHub doesn't have something like GitLab's allow_failure that shows that the pipeline fails without blocking the PR (actions/runner#2347).

I've pushed a job that fails if clippy fails for now. Do you have a better idea ?

@pdeljanov
Copy link
Owner

Thanks @a1phyr, I think we can run with it. It was only a preference, but it's probably better anyways to have it be mandatory. Let's see how it goes.

I added a commit that updates the contribution guidelines to note that clippy is mandatory now. I also renamed the clippy job to be more clear.

@pdeljanov pdeljanov merged commit a24cb97 into pdeljanov:master Feb 29, 2024
11 checks passed
@a1phyr a1phyr deleted the improve_ci branch March 25, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants