Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opus: handle identification header. #59

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

thinking-tower
Copy link

@pdeljanov, could you create another branch for Opus? The opus should be kept for reference for now.

Description

Part of the work for #8.

Porting over code from opus branch and verifying that it matches RFC 7845.

@pdeljanov pdeljanov changed the base branch from master to opus-dev October 2, 2021 02:03
@pdeljanov
Copy link
Owner

Hey @thinking-tower, I made a new opus-dev branch for this work. I can delete the old opus branch once all the existing code is ported over to prevent any confusion.

@thinking-tower
Copy link
Author

@pdeljanov Awesome, could you review this PR?

@thinking-tower thinking-tower force-pushed the feature/opus branch 2 times, most recently from 62b382c to e6a483f Compare October 3, 2021 05:29
symphonia-codec-opus/src/lib.rs Outdated Show resolved Hide resolved
@pdeljanov
Copy link
Owner

Hi @thinking-tower, please see the review comment. Everything else looks okay to me.

- port code from old opus branch.
@thinking-tower
Copy link
Author

@pdeljanov I've changed the names of the test to be shorter than 100 characters, with longest being 62 characters long.

@pdeljanov pdeljanov merged commit a30bf6a into pdeljanov:opus-dev Oct 5, 2021
@pdeljanov
Copy link
Owner

Thanks, I've merged this now!

A suggestion for next time though: try not to rebase your PR branch and force push since it makes viewing changes impossible and removes the approval to run the CI automatically. I generally always squash PR branches into a single commit before merging so there's no need to worry about a messy history.

Cheers!

pdeljanov pushed a commit that referenced this pull request Feb 22, 2022
Port from existing opus branch.
pdeljanov pushed a commit that referenced this pull request Feb 22, 2022
Port from existing opus branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants