-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opus: handle identification header. #59
Conversation
Hey @thinking-tower, I made a new |
b1df396
to
0ac58aa
Compare
@pdeljanov Awesome, could you review this PR? |
62b382c
to
e6a483f
Compare
Hi @thinking-tower, please see the review comment. Everything else looks okay to me. |
- port code from old opus branch.
e6a483f
to
6668e41
Compare
@pdeljanov I've changed the names of the test to be shorter than |
Thanks, I've merged this now! A suggestion for next time though: try not to rebase your PR branch and force push since it makes viewing changes impossible and removes the approval to run the CI automatically. I generally always squash PR branches into a single commit before merging so there's no need to worry about a messy history. Cheers! |
Port from existing opus branch.
Port from existing opus branch.
@pdeljanov, could you create another branch for Opus? The
opus
should be kept for reference for now.Description
Part of the work for #8.
Porting over code from
opus
branch and verifying that it matches RFC 7845.