Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for phive, sign PHAR builds #397

Closed
5 tasks done
tvbeek opened this issue Nov 1, 2019 · 3 comments
Closed
5 tasks done

Support for phive, sign PHAR builds #397

tvbeek opened this issue Nov 1, 2019 · 3 comments

Comments

@tvbeek
Copy link
Member

tvbeek commented Nov 1, 2019

Description

I think that if we have signed PHAR files for PHPMD we can use the same for PHP_Depend. The steps that are needed:

Checks before submitting

  • Be sure that there isn't already an issue about this. See: Issues list
  • Be sure that there isn't already a pull request about this. See: Pull requests
  • Tell if you have the option to provide the code for this proposal.
  • This issue is about 1 feature proposal and nothing more.
  • The issue has a descriptive title. For example: "Support nullable types".
@tvbeek
Copy link
Member Author

tvbeek commented Nov 1, 2019

And then I see we miss the phar file in the releases (See #364 ) There is a pull request #372 but that does multiple things.

tvbeek added a commit to tvbeek/pdepend that referenced this issue Apr 13, 2023
tvbeek added a commit to tvbeek/pdepend that referenced this issue Apr 13, 2023
AJenbo added a commit that referenced this issue Apr 15, 2023
Setup the signing of the phar file. Needed for Phive #397
@tvbeek
Copy link
Member Author

tvbeek commented Sep 15, 2023

@ravage84 I assign this to you because if I'm correctly the only missing step is the keys that you need to set in the secrets 😃

Sorry wrong project.

@tvbeek
Copy link
Member Author

tvbeek commented Sep 15, 2023

This is already finished

@tvbeek tvbeek closed this as completed Sep 15, 2023
@ravage84 ravage84 added this to the 2.x (unspecific) milestone May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants