Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't reset value of ASTFormalParameter::$modifiers when sleep #555

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Don't reset value of ASTFormalParameter::$modifiers when sleep #555

merged 1 commit into from
Jul 29, 2021

Conversation

YAhiru
Copy link

@YAhiru YAhiru commented Jul 29, 2021

Type: bugfix
Breaking change: no

Don't reset value of ASTFormalParameter::$modifiers when sleep

$param = new ASTFormalParameter();
$param->setModifiers(State::IS_PRIVATE);

// Current Behavior        
var_dump(unserialize(serialize($param))); // ASTFormalParameter::$modifiers => 0

// this PR
var_dump(unserialize(serialize($param))); // ASTFormalParameter::$modifiers => 4

@YAhiru YAhiru mentioned this pull request Jul 29, 2021
Merged
kylekatarnls
kylekatarnls approved these changes Jul 29, 2021
View reviewed changes
Copy link
Member

@kylekatarnls kylekatarnls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much 🙏

@kylekatarnls kylekatarnls modified the milestones: 2.10.0, 2.10.1 Jul 29, 2021
@kylekatarnls kylekatarnls merged commit abf6351 into pdepend:master Jul 29, 2021
@YAhiru YAhiru deleted the feature/fix-formal-parameter-reset-modifiers-when-sleep branch July 29, 2021 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylekatarnls kylekatarnls kylekatarnls approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
2.10.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@YAhiru @kylekatarnls