Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keywords to composer.json #657

Merged
merged 2 commits into from Apr 15, 2023
Merged

Conversation

tvbeek
Copy link
Member

@tvbeek tvbeek commented Mar 20, 2023

Keywords to describe pdepend
Dev to let composer know the package is mostly a dev dependency, see: composer/composer#10960

Type: feature
Issue: -
Breaking change: no

With adding dev as keyword composer will suggest it as dev package if someone install it with composer require without --dev.

I found out it didn't had any keywords so I added some, maybe there are other keywords that make sense to add.

Keywords to describe pdepend
Dev to let composer know the package is mostly a dev dependency, see: composer/composer#10960
@tvbeek tvbeek self-assigned this Mar 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2627cab) 82.09% compared to head (11916a1) 82.09%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #657   +/-   ##
=========================================
  Coverage     82.09%   82.09%           
  Complexity     3440     3440           
=========================================
  Files           154      154           
  Lines          9466     9466           
=========================================
  Hits           7771     7771           
  Misses         1695     1695           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tvbeek
Copy link
Member Author

tvbeek commented Mar 20, 2023

@AJenbo The phpstan job failed on code I didn't changed. Does it mean we need to pin the PHPStan version or is there another reason?

@AJenbo
Copy link
Collaborator

AJenbo commented Mar 21, 2023

@AJenbo The phpstan job failed on code I didn't changed. Does it mean we need to pin the PHPStan version or is there another reason?

Yeah it's a down side with how we have things setup. PHPStan requires PHP 7.2 so we have it in the composer.json/lock file since it needs to allow for versions going all the way back to PHP 5.3. So instead we require it during CI (running on PHP 7.4).

Right now it semi pinned because it will pull the last version that was installed from cache in most cases.

I guess we could specify the given version in the composer command that installs it.

@AJenbo
Copy link
Collaborator

AJenbo commented Mar 21, 2023

Here is a fix for the detected issue: #658

You should be able to pin the PHPStan version by changing this from a range to an explicit version:
https://github.com/pdepend/pdepend/blob/master/.github/workflows/phpstan.yml#L47

@AJenbo AJenbo merged commit 6db1536 into pdepend:master Apr 15, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants