Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Gtk.Application #55

Closed
jeromerobert opened this issue Feb 10, 2019 · 4 comments
Closed

Switch to Gtk.Application #55

jeromerobert opened this issue Feb 10, 2019 · 4 comments

Comments

@jeromerobert
Copy link
Member

Working on #52 and #44 I have the feeling that pdfarranger should first use the UI action concept. It should be straightforward to introduce Gtk.Action but it's deprecated so I would prefer to invest time on Gtk.Application. This looks like a somehow intrusive and long work so this issue, #52 and #44 will probably remain open for a while.

@dreua
Copy link
Member

dreua commented Feb 20, 2019

Sounds good to me, let me know if I can be of any assistance!

As a side note, I think it might be a good idea to break the 1300 line beast that pdfarranger.py currently is down into smaller pieces. What do you think?

@jeromerobert
Copy link
Member Author

As a side note, I think it might be a good idea to break the 1300 line beast that pdfarranger.py
currently is down into smaller pieces. What do you think?

I agree it's a bit hard to read but I think the main issue is the size of the PdfArranger class, not the size of the pdfarranger.py file. Unless I'm wrong introducing a Gtk.Application class should help because we'll have actions in a class and GUI layout in an other one. Anyway once implemented move the application file to a new file should be easy.

@jeromerobert
Copy link
Member Author

jeromerobert commented Mar 14, 2019

@dreua finally that did not help to make the code clearer. I think we should create an IconView class, this would make the PdfArranger thiner.

@dreua
Copy link
Member

dreua commented Mar 18, 2019

@jeromerobert I disagree, I think the code became clearer in many places, thank you for your ongoing maintenance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants