Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render borders with width 0 #689

Closed
roromix opened this issue Aug 28, 2023 · 5 comments
Closed

Render borders with width 0 #689

roromix opened this issue Aug 28, 2023 · 5 comments
Assignees

Comments

@roromix
Copy link
Contributor

roromix commented Aug 28, 2023

When we create a table specifying border.width = 0, the borders and the grid are still drawn.

I will create a merge request to fix this problem.

@hhrutter
Copy link
Collaborator

Hello!

Please describe your use case.
Are you using the API or the CLI.

Generally for pdfcpu drawing primitives the border width translates into a line width.
That means a border width of 0 translates into the thinnest border.

The left table has border width 0, the right one has border width 1:
Screenshot 2023-08-28 at 18 34 27

The issue at hand is distinguishing between no border and border width 0.

@roromix
Copy link
Contributor Author

roromix commented Aug 29, 2023

Hi @hhrutter ,
I'm using the API, and my goal is to have no border.

@roromix
Copy link
Contributor Author

roromix commented Aug 29, 2023

We have to create a new property for disable border ?

@hhrutter
Copy link
Collaborator

Maybe, I am looking into this.

@hhrutter
Copy link
Collaborator

This is fixed with the latest commit.
In your case you want to provide a table without border and set table.Grid to false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants