Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLs being escaped after upgrade to 0.5.3 #166

Closed
KidkArolis opened this issue Mar 4, 2013 · 4 comments · Fixed by #312
Closed

URLs being escaped after upgrade to 0.5.3 #166

KidkArolis opened this issue Mar 4, 2013 · 4 comments · Fixed by #312
Assignees
Milestone

Comments

@KidkArolis
Copy link

Our PDF generation broke after update to 0.5.3

The URL we're opening is something like

PDFKit.new("http://localhost/?some_param=1", {})

In 0.5.3, that URL is converted to something like (I checked in the server's access log):

http://localhost/\?some_param=1

and the request fails.

@0xCCD
Copy link

0xCCD commented Mar 8, 2013

Same problem, 0.5.3 shattered my header and footer,

kit = PDFKit.new(html, :"header-html"=>newsletter_pdf_header_url(@newsletter), :"footer-html"=>newsletter_pdf_footer_url(@newsletter))

Url looks like
/newsletters/7132/pdf/header%5C
instead of
/newsletters/7132/pdf/header

@glampr
Copy link

glampr commented Apr 23, 2013

I have the same issue.
I try to turn this URL into a pdf

http://127.0.0.1:3001/el/users/524.print?to=pdf

but this is what I get in the server logs

Started GET "/el/users/524.print%5C?to%5C=pdf"

@0xCCD
Copy link

0xCCD commented Apr 23, 2013

For me i've solved it with

gem 'pdfkit', '=0.5.2'

@cdwort
Copy link
Contributor

cdwort commented Jul 7, 2015

I believe this is related to #164, which lead to this commit: ce37ffc

We are now using shelljoin instead of shellescape, but I imagine the issue may still remain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants