Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ignore error option #392

Closed
egh opened this issue Mar 9, 2017 · 2 comments
Closed

Support ignore error option #392

egh opened this issue Mar 9, 2017 · 2 comments

Comments

@egh
Copy link

egh commented Mar 9, 2017

When wkhtmltopdf exits with non-0 exit status, pdfkit will (generally) throw an exception.

This is not always ideal. See, e.g. the upstream bug wkhtmltopdf/wkhtmltopdf#3380

It would be nice to have an option to pdfkit to ignore (that is, not raise an exception) for non-0 exit statuses that nonetheless generate a PDF.

@ownadi
Copy link

ownadi commented May 24, 2017

It could be useful feature. I created a pr (#395) that adds this ability.

@github-actions
Copy link

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants