Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Middleware does not conform to Rack SPEC #414

Closed
wagenet opened this issue Dec 20, 2017 · 4 comments
Closed

Middleware does not conform to Rack SPEC #414

wagenet opened this issue Dec 20, 2017 · 4 comments
Labels
no-issue-activity

Comments

@wagenet
Copy link

wagenet commented Dec 20, 2017 •
edited
Loading

The spec states:

If the body is replaced by a middleware after action, the original body must be closed first, if it responds to close.

However, we can see that this does not happen:
https://github.com/pdfkit/pdfkit/blob/master/lib/pdfkit/middleware.rb#L19
@github-actions
Copy link

Stale issue message

@wagenet
Copy link
Author

wagenet commented Jan 27, 2020

I believe this is still an issue, though the line number is no longer accurate.

@github-actions github-actions bot closed this as completed Feb 4, 2020
@wagenet
Copy link
Author

wagenet commented Feb 4, 2020

@serene not sure if you're the right person to handle this, but I believe this is still an issue.

@serene
Copy link
Contributor

serene commented Feb 5, 2020

@wagenet Can you throw together a quick PR?

@serene serene reopened this Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
no-issue-activity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wagenet @serene