Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File.exists? is deprecated #498

Closed
BrianHawley opened this issue Dec 21, 2021 · 2 comments · Fixed by #499 or rhiroshi/pdfkit#1
Closed

File.exists? is deprecated #498

BrianHawley opened this issue Dec 21, 2021 · 2 comments · Fixed by #499 or rhiroshi/pdfkit#1
Labels
no-issue-activity

Comments

@BrianHawley
Copy link
Contributor

BrianHawley commented Dec 21, 2021 •
edited

File.exists? is deprecated, and this prints out a deprecation warning on Ruby 3.0+. Change to File.exist? everywhere.

I'll make a PR.
BrianHawley added a commit to BrianHawley/pdfkit that referenced this issue Dec 21, 2021
@BrianHawley
Update for new Ruby and Rails versions
02b9d07 
- Test Ruby 2.7 and 3.0, and Rails 6.1 and 7.0.
- Exclude incompatible test matrix combinations.
- Show Ruby deprecation warnings in tests where supported.
- File.exists? is deprecated; use File.exist?.
- URI.escape and URI.decode are deprecated.
- Add frozen string literal comments.
- Make sure constants are frozen.
- Make sure that the code is frozen-string safe.
- Adjust dev dependencies for Ruby 3.0 compatibility.

Fixes pdfkit#498
@BrianHawley BrianHawley mentioned this issue Dec 21, 2021
Merged
BrianHawley added a commit to BrianHawley/pdfkit that referenced this issue Dec 21, 2021
@BrianHawley
Update for new Ruby and Rails versions
63f4222 
- Test Ruby 2.7 and 3.0, and Rails 6.1 and 7.0.
- Exclude incompatible test matrix combinations.
- Show Ruby deprecation warnings in tests where supported.
- File.exists? is deprecated; use File.exist?.
- URI.escape and URI.decode are deprecated.
- Add frozen string literal comments.
- Make sure constants are frozen.
- Make sure that the code is frozen-string safe.
- Adjust dev dependencies for Ruby 3.0 compatibility.
- Fix Ruby warnings in pdfkit_spec.rb
- Comment out bad syntax in release-drafter action.

Fixes pdfkit#498
BrianHawley added a commit to BrianHawley/pdfkit that referenced this issue Jan 6, 2022
@BrianHawley
Update for new Ruby and Rails versions
c9c1448 
- Test Ruby 2.7, 3.0, and 3.1, and Rails 6.1 and 7.0.
- Exclude incompatible test matrix combinations.
- Show Ruby deprecation warnings in tests where supported.
- File.exists? is deprecated; use File.exist?.
- URI.escape and URI.decode are deprecated.
- Add frozen string literal comments.
- Make sure constants are frozen.
- Make sure that the code is frozen-string safe.
- Adjust dev dependencies for Ruby 3.0+ compatibility.
- Fix Ruby warnings in pdfkit_spec.rb
- Comment out bad syntax in release-drafter action.

Fixes pdfkit#498
@rhiroshi rhiroshi mentioned this issue Feb 8, 2022
Merged
@github-actions
Copy link

This issue has been marked as stale and will be automatically closed.

BrianHawley added a commit to BrianHawley/pdfkit that referenced this issue Apr 4, 2022
@BrianHawley
Update for new Ruby and Rails versions
b06c5fd 
- Test Ruby 2.7, 3.0, and 3.1, and Rails 6.1 and 7.0.
- Exclude incompatible test matrix combinations.
- Show Ruby deprecation warnings in tests where supported.
- File.exists? is deprecated; use File.exist?.
- URI.escape and URI.decode are deprecated.
- Add frozen string literal comments.
- Make sure constants are frozen.
- Make sure that the code is frozen-string safe.
- Adjust dev dependencies for Ruby 3.0+ compatibility.
- Fix Ruby warnings in pdfkit_spec.rb
- Comment out bad syntax in release-drafter action.

Fixes pdfkit#498
BrianHawley added a commit to BrianHawley/pdfkit that referenced this issue Apr 4, 2022
@BrianHawley
Update for new Ruby and Rails versions
4c48ec8 
- Update default ruby version to latest 2.6 release.
- Test Ruby 2.7, 3.0, and 3.1, and Rails 6.1 and 7.0.
- Use latest rubygems and bundler to fix the bundler cache.
- Exclude incompatible test matrix combinations.
- Show Ruby deprecation warnings in tests where supported.
- File.exists? is deprecated; use File.exist?.
- URI.escape and URI.decode are deprecated.
- Add frozen string literal comments.
- Make sure constants are frozen.
- Make sure that the code is frozen-string safe.
- Adjust dev dependencies for Ruby 3.0+ compatibility.
- Fix Ruby warnings in pdfkit_spec.rb
- Comment out bad syntax in release-drafter action.

Fixes pdfkit#498
BrianHawley added a commit to BrianHawley/pdfkit that referenced this issue Apr 4, 2022
@BrianHawley
Update for new Ruby and Rails versions
36ffbfb 
- Update default ruby version to latest 2.6 release.
- Test Ruby 2.7, 3.0, and 3.1, and Rails 6.1 and 7.0.
  Use versions as strings to make sure 3.0 tests 3.0.
- Use latest rubygems and bundler to fix the bundler cache.
- Exclude incompatible test matrix combinations.
- Show Ruby deprecation warnings in tests where supported.
- File.exists? is deprecated; use File.exist?.
- URI.escape and URI.decode are deprecated.
- Add frozen string literal comments.
- Make sure constants are frozen.
- Make sure that the code is frozen-string safe.
- Adjust dev dependencies for Ruby 3.0+ compatibility.
- Fix Ruby warnings in pdfkit_spec.rb
- Comment out bad syntax in release-drafter action.

Fixes pdfkit#498
serene pushed a commit that referenced this issue Apr 11, 2022
@BrianHawley
Update for new Ruby and Rails versions (#499)
965c1bb 
- Update default ruby version to latest 2.6 release.
- Test Ruby 2.7, 3.0, and 3.1, and Rails 6.1 and 7.0.
  Use versions as strings to make sure 3.0 tests 3.0.
- Use latest rubygems and bundler to fix the bundler cache.
- Exclude incompatible test matrix combinations.
- Show Ruby deprecation warnings in tests where supported.
- File.exists? is deprecated; use File.exist?.
- URI.escape and URI.decode are deprecated.
- Add frozen string literal comments.
- Make sure constants are frozen.
- Make sure that the code is frozen-string safe.
- Adjust dev dependencies for Ruby 3.0+ compatibility.
- Fix Ruby warnings in pdfkit_spec.rb
- Comment out bad syntax in release-drafter action.

Fixes #498
@antarr
Copy link

antarr commented Feb 23, 2023

Is this released yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
no-issue-activity
Projects
None yet
Milestone
No milestone
2 participants
@BrianHawley @antarr