Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to render stylesheets as html safe string on Rails 6 #483

Merged
merged 5 commits into from Jan 24, 2021
Merged

Fix to render stylesheets as html safe string on Rails 6 #483

merged 5 commits into from Jan 24, 2021

Commits on Jan 6, 2021

  1. Drop legacy Ruby versions 

    They are currently unmaintained.
    @tricknotes
    tricknotes committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    26e33be View commit details
    Browse the repository at this point in the history

  2. Run CI against multiple Rails versions

    @tricknotes
    tricknotes committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    b992b2f View commit details
    Browse the repository at this point in the history

  3. Add failing spec on Rails 6.0

    @tricknotes
    tricknotes committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    760a8ed View commit details
    Browse the repository at this point in the history

  4. Use ActiveSupport::SafeBuffer#html_safe if it is available 

    PDFKit concats HTML. So, it should not be escaped.
    @tricknotes
    tricknotes committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    4338b9a View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2021

  1. Document supported versions 

    Now, pdfkit supports Ruby 2.5 or later.
    @tricknotes
    tricknotes committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    5be849c View commit details
    Browse the repository at this point in the history