Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable tests on GitHub Actions #502

Merged
merged 4 commits into from
Apr 4, 2022
Merged

Enable tests on GitHub Actions #502

merged 4 commits into from
Apr 4, 2022

Conversation

leonyip
Copy link
Contributor

@leonyip leonyip commented Apr 3, 2022

Migrate from TravisCI to Github Actions. Please note that the wkhtmltopdf binary had been updated to the latest 0.12.6-1 in the test workflow.

@leonyip leonyip mentioned this pull request Apr 3, 2022
Merged
@serene
Copy link
Contributor

serene commented Apr 4, 2022

Thank you so much for taking time to do this.

@serene serene merged commit ecd18e6 into pdfkit:master Apr 4, 2022
@serene
Copy link
Contributor

serene commented Apr 4, 2022

@leonyip There is an issue after merge:
image

@leonyip
Copy link
Contributor Author

leonyip commented Apr 4, 2022

@serene seems like GitHub doesn't like that empty string now. I opened PR #503 to remove it from the release drafter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leonyip @serene