Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing a Pathname object to the path argument #522

Merged

Conversation

yujideveloper
Copy link
Contributor

I got the below error when passing Pathname object to PDFKit#to_file in PDFKit v0.8.7.2.

TypeError:
  no implicit conversion of Pathname into String
# /bundle/ruby/2.7.0/gems/pdfkit-0.8.7.2/lib/pdfkit/pdfkit.rb:71:in `popen'
# /bundle/ruby/2.7.0/gems/pdfkit-0.8.7.2/lib/pdfkit/pdfkit.rb:71:in `to_pdf'
# /bundle/ruby/2.7.0/gems/pdfkit-0.8.7.2/lib/pdfkit/pdfkit.rb:84:in `to_file'

I think this error introduced in v0.8.7.2(#519).

@serene serene added the ready label Nov 3, 2022
@github-actions
Copy link

github-actions bot commented Jan 3, 2023

This pull request has been marked as stale and will be automatically closed.

@yujideveloper
Copy link
Contributor Author

@serene
Thank you for your review. Could you merge this PR?

@github-actions github-actions bot closed this Jan 11, 2023
@serene serene reopened this Jan 11, 2023
@serene serene merged commit 29a3dd4 into pdfkit:master Jan 11, 2023
@yujideveloper yujideveloper deleted the bugfix/allow-pass-pathname-object-to-path branch January 11, 2023 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants