Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets the button type to "button" #280

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Sets the button type to "button" #280

merged 2 commits into from
Oct 17, 2023

Conversation

dkastl
Copy link
Contributor

@dkastl dkastl commented Oct 16, 2023

Problem

When the designer is embedded in a form element, clicking on the sidebar expand > button or the "Add new field" button submits the form.

Proposed solution

When the buttons are declared as type="button" clicking does not trigger a form submit.

@hand-dot
Copy link
Collaborator

Hey @dkastl ,
Thank you, I'd like to merge this PR, can you update snapshot test?
you just run npm test -- -u in the ui package.

Signed-off-by: Daniel Kastl <daniel@georepublic.de>
@hand-dot
Copy link
Collaborator

@dkastl
Thank you for your contribution.

We are currently working on version 3. This fix is planned to be incorporated in version 3 and beyond.

If you want to use this merged change immediately, please create a fork for yourself and use that.

@hand-dot hand-dot merged commit cf36b1b into pdfme:main Oct 17, 2023
1 check passed
@dkastl dkastl deleted the patch-1 branch October 17, 2023 04:46
@dkastl
Copy link
Contributor Author

dkastl commented Oct 17, 2023

Thanks a lot @hand-dot !
I'm just exploring at the moment and I'm looking forward to version 3, because custom schema is probably what I need as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants