Set Rotate from propPanel default schema #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hand-dot
commented
Oct 26, 2023
| @@ -242,6 +242,10 @@ const Main = (props: Props, ref: Ref<HTMLDivElement>) => { | |||
| setEditing(true); | |||
| }; | |||
|
|
|||
| const rotatable = schemasList[pageCursor] | |||
There was a problem hiding this comment.
detect rotatable or not
| @@ -135,6 +135,9 @@ export const propPanel: PropPanel<TextSchema> = { | |||
| position: { x: 0, y: 0 }, | |||
| width: 45, | |||
| height: 10, | |||
| // If the value of "rotate" is set to undefined or not set at all, rotation will be disabled in the UI. | |||
| // Check this document: https://pdfme.com//docs/custom-schemas#learning-how-to-create-from-pdfmeschemas-code | |||
| rotate: 0, | |||
There was a problem hiding this comment.
set rotate as number
hand-dot
commented
Oct 26, 2023
| const ids = activeElements.map((ae) => ae.id); | ||
| const activeSchema = schemas.find((s) => ids.includes(s.id)); | ||
|
|
||
| if (activeSchema?.type === 'text') { |
|
nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of mandating the implementation of 'rotate' for all elements, which would increase the developer's workload, allow for the omission of 'rotate' implementation on a case-by-case basis.
If 'rotate' is set here, enable rotate in the Designer, and if 'rotate' is not set here, make rotate unavailable.