New basePdf type and Support adding new pages to template #394

hand-dot · 2023-12-27T06:59:06Z

ref:

TODO

padding (This is used for page breaks by dynamic tables and the draggable area in the designer.)
add / remove page from designer function
add/remove page button ui design
~~add ui to set padding~~
~~add demo to website and playground(because this feature is not available if basePdf doesn't have width and height this feature will not be shown existing site)~~ -> Create a demo of a blank PDF and a dynamic table #401

preview

My.Movie.mp4

vercel · 2023-12-27T06:59:11Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
pdfme-playground	⬜️ Ignored (Inspect)	Visit Preview		Jan 3, 2024 7:46am

packages/generator/src/helper.ts

hand-dot

@peteward
If you have time, could you check this PR?
Of course, I would prefer you to prioritize family time over the review.

hand-dot · 2023-12-31T01:47:48Z

packages/generator/__tests__/assets/templates/pet.json

@@ -404,7 +404,16 @@
      }
    }
  ],
-  "basePdf": "data:application/pdf;base64,JVBERi0xLjcKJYGBgYEKCjUgMCBvYmoKPDwKL0ZpbHRlciAvRmxhdGVEZWNvZGUKL0xlbmd0aCAzOAo+PgpzdHJlYW0KeJwr5DJQMFAwtTTVMzFRsDAx1LM0UihK5QrX4srjCuQCAF0PBgoKZW5kc3RyZWFtCmVuZG9iagoKNiAwIG9iago8PAovVHlwZSAvWE9iamVjdAovU3VidHlwZSAvRm9ybQovRm9ybVR5cGUgMQovQkJveCBbIDAgMCA1OTUuNDQgODQxLjkyIF0KL01hdHJpeCBbIDEgMCAwIDEgMCAwIF0KL1Jlc291cmNlcyA8PAovRm9udCA8PAo+PgovWE9iamVjdCA8PAo+PgovRXh0R1N0YXRlIDw8Cj4+Cj4+Ci9GaWx0ZXIgL0ZsYXRlRGVjb2RlCi9MZW5ndGggNDIKPj4Kc3RyZWFtCnicK+TiKuQyUDBQMLU01TMxUbAwMdSzNFIoSuUK1+LK4wrkAiEAiY4G/gplbmRzdHJlYW0KZW5kb2JqCgo4IDAgb2JqCjw8Ci9GaWx0ZXIgL0ZsYXRlRGVjb2RlCi9MZW5ndGggNTMKPj4Kc3RyZWFtCnicK+QyVDAAQgiZnEsaV981Nyk1JSU1JSAlLSAxPVXX3MDSwsTCwNzCUsElnyuQCwCP+hS9CmVuZHN0cmVhbQplbmRvYmoKCjkgMCBvYmoKPDwKL0ZpbHRlciAvRmxhdGVEZWNvZGUKL0xlbmd0aCAyNDQKPj4Kc3RyZWFtCnicKykqTWVgY3BgYGJQyEhNTGGAgBwgNssACkD5i4BYJSc/GcY/BsQsuYkVBVD+KSBWSM+pTIPyXwFxREZuSQWEy+gEUs/ACGIysi1R9Pscz2/zlUGb+QVI9urfbzog+prmpud/xH6/4C5gFwByOYBuAmsGau34d4CBgXvHH7H/ntwFYHOQAYivAzWdmUETLMYEFgeJOUBVsTKk/O9gbmEuYGAG+piTgYeBn4FBXFBRkJNRkZNREEKkMCv8K2C0+9vCGAckU5hq/h36t4jRroL5xR8JJlnGmf/s/qUzG/1ZyjiT8dCfc4wzGRiAfkgBAPGLP6AKZW5kc3RyZWFtCmVuZG9iagoKMTIgMCBvYmoKPDwKL0ZpbHRlciAvRmxhdGVEZWNvZGUKL0xlbmd0aCAyMTcKPj4Kc3RyZWFtCnicXVDLjsMgDLzzFT62h4q05yjSqr3k0Iea3Q8gYFKkxiCHHPL3CyTqSmsJZHtm8Bh5bi8tuQjywV53GME6MoyTn1kj9Dg4EscTGKfjVpVbjyoImcTdMkUcW7Ie6loAyGeCp8gL7L6M73Gfe3c2yI4G2P2cu9Lp5hDeOCJFqETTgEGbnruqcFMjgizSQ2sS7uJySKo/xvcSEE6lPq6WtDc4BaWRFQ0o6ipFU9sUjUAy/+BqFfVWvxSLTNjSTM1rfWzomTk5KLuX0XmoI/x8T/Ahq/L5BVXUbZ8KZW5kc3RyZWFtCmVuZG9iagoKMTMgMCBvYmoKPDwKL0ZpbHRlciAvRmxhdGVEZWNvZGUKL0xlbmd0aCAxMAo+PgpzdHJlYW0KeJwr5AIAAO4AfAplbmRzdHJlYW0KZW5kb2JqCgoxNCAwIG9iago8PAovRmlsdGVyIC9GbGF0ZURlY29kZQovTGVuZ3RoIDEwCj4+CnN0cmVhbQp4nAvkAgAArgBcCmVuZHN0cmVhbQplbmRvYmoKCjE1IDAgb2JqCjw8Ci9GaWx0ZXIgL0ZsYXRlRGVjb2RlCi9UeXBlIC9PYmpTdG0KL04gNwovRmlyc3QgNDEKL0xlbmd0aCA2MTMKPj4Kc3RyZWFtCnic1VRLb9pAEL77V8wxOZB9YPyookiAcUKrNCjQNmrVw8JOXFdmF9mLFP59Zm0smkZpe63wmN157cx831oABwlhCEOIEwhhxBOIIQpTEBxSPgQh6KH15WXAVocdAluoApuAfSh1A9/ImcM9fA/Y1O6NAxFcXQUn36lyqrJF0AWB8M69x6K2er/BGi7zWZ5zHnPOo5AkIslIRpxL0smE1iRxeBTSxUPOh2Oy5Z1EpIzSzt76UmxEwXJG/+Qb5V3O1tfnEySz7jyZHc/Nu3j5Vi3pVcBurc6UQzjL3kkuh0JKyQU94us5jaBG5ez/1VBbc2nNm129wDO3xgVsuV+7duuVPGAT1aC3AFsqQvRGmaUyzfvF4B6LfaXqQRqHMmAzs7G6NAWwuUbjSncY3AQsw2aDRivjfApPKSF6Tq3sJ1NSEIKQv1LnRETPrBo98Vo7u8fG7usNcc37tUXRgsLYw936J27aLZtt16g16oV+9EkGMU+TMOFxkkLUn8NmT+566fxYugxed4u6VBP7RFVy+o3S0QXdnSQUF6n0BY+NsW0P7YUwDruOkr6hSYWo/xC/qsvt2+ZXUPjZ1eWOONf1+lFt8S8g5JUqGgg7/0l31oDII/07TECmMgGR0GeAypnT7S03Y1NUCITz2CNFoxYR73FzMBhK2k3V7gbL4kdvfTjuaLl0uP3sF/7EvKxQQvoazN+YNZ1nXuNtVDTtVvZ6nt2q3Yk8/8w7il4eGqpibh5tiz/Zy8bVBzgba7tGurp3tcbac/OsT3/uq9ntKtz6LnkL/8uZ+09kS7ovNEOCvEPoGVfAZIUKZW5kc3RyZWFtCmVuZG9iagoKMTYgMCBvYmoKPDwKL1NpemUgMTcKL1Jvb3QgMiAwIFIKL0luZm8gMyAwIFIKL0ZpbHRlciAvRmxhdGVEZWNvZGUKL1R5cGUgL1hSZWYKL0xlbmd0aCA2NwovVyBbIDEgMiAyIF0KL0luZGV4IFsgMCAxNyBdCj4+CnN0cmVhbQp4nCXJQRGAMBBD0Z9tC5wAU3hBBQYqCSeYKZvp5c38BBgjOMDIhCniBPHMo0o9M7aZzSwqV271Nm/S9mT94AcTJgYfCmVuZHN0cmVhbQplbmRvYmoKCnN0YXJ0eHJlZgoyMDEwCiUlRU9G",
+  "basePdf": {


The main part of what I did in this PR is that I made it so that we can set it with a new type called BlankPdf instead of PDF data in basePdf.

packages/ui/src/components/Designer/Sidebar/DetailView/index.tsx

packages/ui/src/components/Designer/index.tsx

peteward

great, some minor comments

vpn-dev · 2024-01-19T03:01:14Z

@hand-dot i am not seeing any option to add pages while in designer, can you help me with it

* TMP * Minor fix * TMP * IMPL Support adding new pages to template #111 * Fix test * Minor fix * IMPL padding behavior * Update snapshot * TMP * Minor fix * Update snapshot * TMP * add i18n * TMP * remove option from BlankPdf.padding * Minor fix * Minor fix * format

* Reconsider the internal data types and the template types (#389) * Change SchemaForUI's data and readOnlyValue to content * Fix bug * Remove sampledata and instead always use content. & Use content regardless of readOnly or not. & Eliminate defaultValue and replace it with always using content. * Change website template * Fix placeholder bug * Change generator test template * Change content to optional * Move getInputFromTemplate to common * Remove columns * Fix test * move dynamictable.excalidraw * remove idea dir * New basePdf type and Support adding new pages to template (#394) * Minor fix * IMPL Support adding new pages to template #111 * Fix test * Minor fix * IMPL padding behavior * Update snapshot * Minor fix * Update snapshot * add i18n * remove option from BlankPdf.padding * Minor fix * Minor fix * format * Add changeSchemas unit test (#403) * Minor fix * Add a version number to pdfme template from V4 onwards (#404) * Impl * Minor fix * Padding move width (#407) * Refactor position and size handling in helper.ts * Fix bug * Add DynamicTable Schema #332 (#408) * [tmp] add some comment * Update snapshot * Add deploy-table script to package.json * add new template for playground * bug fix for form * fix cell editing bug * Fix Adding rows doesn't change the overall height of the table * fix padding problem * Fix build error * Fix bug * Minor fix * Fix New lines not reflecting correctly * minor fix * Minor fix * Change tableStyles def * add i18n * small bugfix * FIx some TODO * Remove japanese comment * Minor fix * Fix infinity loom for form * fix save inputs bug * fix window resize bug * add skip for failing test and update snapshot * Minor fix * add presets for playground * Minor fix * Reconsider the internal data types and the template types (#389) * Change SchemaForUI's data and readOnlyValue to content * Fix bug * Remove sampledata and instead always use content. & Use content regardless of readOnly or not. & Eliminate defaultValue and replace it with always using content. * Change website template * Fix placeholder bug * Change generator test template * Change content to optional * Move getInputFromTemplate to common * Remove columns * Fix test * move dynamictable.excalidraw * remove idea dir * New basePdf type and Support adding new pages to template (#394) * Minor fix * IMPL Support adding new pages to template #111 * Fix test * Minor fix * IMPL padding behavior * Update snapshot * Minor fix * Update snapshot * add i18n * remove option from BlankPdf.padding * Minor fix * Minor fix * format * Add changeSchemas unit test (#403) * Minor fix * Add a version number to pdfme template from V4 onwards (#404) * Impl * Minor fix * Padding move width (#407) * Refactor position and size handling in helper.ts * Fix bug * Add DynamicTable Schema #332 (#408) * [tmp] add some comment * Update snapshot * Add deploy-table script to package.json * add new template for playground * bug fix for form * fix cell editing bug * Fix Adding rows doesn't change the overall height of the table * fix padding problem * Fix build error * Fix bug * Minor fix * Fix New lines not reflecting correctly * minor fix * Minor fix * Change tableStyles def * add i18n * small bugfix * FIx some TODO * Remove japanese comment * Minor fix * Fix infinity loom for form * fix save inputs bug * fix window resize bug * add skip for failing test and update snapshot * Minor fix * add presets for playground * Minor fix * Minor fix * Update imports and fix font rendering * Add a Left Sidebar for Placing Schemas #400 (#452) * Remove original 'Add new field' Button * add icon * FIx drag position bug * Minor fix * Fix sidebar position * Update snapshot * Minor fix * Update packages/ui/src/components/Designer/index.tsx Co-authored-by: Peter Ward <pete@pennyblack.io> --------- Co-authored-by: Peter Ward <pete@pennyblack.io> * Fix test * Improve left sidebar icon drop placement accuracy (#454) * Fix Spanish translations for v4 (#463) * Fix #431 * V4 (#467) * feat: add french language * feat: relecture * feat: add french language --------- Co-authored-by: regis <regis> * Add French language option to playground * rename table export name to tableBeta --------- Co-authored-by: Peter Ward <pete@pennyblack.io> Co-authored-by: Iker Diez <32014358+ikerd@users.noreply.github.com> Co-authored-by: Régis <regis.charnace@leandco.fr>

hand-dot added 2 commits December 27, 2023 15:54

TMP

e066224

Minor fix

4f99d7c

hand-dot changed the title ~~New basePdf type and Support adding new pages to template~~ [WIP] New basePdf type and Support adding new pages to template Dec 27, 2023

peteward reviewed Dec 27, 2023

View reviewed changes

packages/generator/src/helper.ts Outdated Show resolved Hide resolved

hand-dot added 2 commits December 27, 2023 17:57

TMP

eea32a8

IMPL Support adding new pages to template #111

bbfd398

This comment was marked as outdated.

Sign in to view

hand-dot added 4 commits December 28, 2023 14:22

Fix test

2836c6b

Minor fix

ff89f16

IMPL padding behavior

a465c85

Update snapshot

59fa9a1

This comment was marked as outdated.

Sign in to view

hand-dot added 3 commits December 29, 2023 14:28

Merge branch 'main' of https://github.com/pdfme/pdfme into base-pdf-type

1cf6ce1

TMP

76a2eb7

Minor fix

3e33ba5

This comment was marked as outdated.

Sign in to view

hand-dot added 5 commits December 30, 2023 22:20

Update snapshot

b2cf9b9

TMP

b9756c2

add i18n

b424a75

TMP

36aace1

remove option from BlankPdf.padding

a7eed57

hand-dot changed the title ~~[WIP] New basePdf type and Support adding new pages to template~~ New basePdf type and Support adding new pages to template Dec 31, 2023

Minor fix

c4dfa70

hand-dot commented Dec 31, 2023

View reviewed changes

hand-dot requested a review from peteward December 31, 2023 01:48

Merge branch 'v4' into base-pdf-type

3a2449c

peteward reviewed Jan 2, 2024

View reviewed changes

packages/ui/src/components/Designer/Sidebar/DetailView/index.tsx Show resolved Hide resolved

peteward reviewed Jan 2, 2024

View reviewed changes

packages/ui/src/components/Designer/index.tsx Show resolved Hide resolved

peteward reviewed Jan 2, 2024

View reviewed changes

packages/ui/src/components/Designer/index.tsx Outdated Show resolved Hide resolved

peteward reviewed Jan 2, 2024

View reviewed changes

hand-dot mentioned this pull request Jan 3, 2024

Create changeSchemas unit test #402

Closed

hand-dot added 2 commits January 3, 2024 16:45

Minor fix

35abe68

format

b96d912

hand-dot merged commit 380842c into v4 Jan 3, 2024
3 checks passed

This was referenced Jan 3, 2024

Support adding new pages to template #111

Closed

New basePdf type #392

Closed

hand-dot deleted the base-pdf-type branch January 9, 2024 05:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New basePdf type and Support adding new pages to template #394

New basePdf type and Support adding new pages to template #394

hand-dot commented Dec 27, 2023 •

edited

vercel bot commented Dec 27, 2023 •

edited

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

hand-dot left a comment

hand-dot Dec 31, 2023

peteward left a comment

vpn-dev commented Jan 19, 2024

New basePdf type and Support adding new pages to template #394

New basePdf type and Support adding new pages to template #394

Conversation

hand-dot commented Dec 27, 2023 • edited

vercel bot commented Dec 27, 2023 • edited

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

hand-dot left a comment

Choose a reason for hiding this comment

hand-dot Dec 31, 2023

Choose a reason for hiding this comment

peteward left a comment

Choose a reason for hiding this comment

vpn-dev commented Jan 19, 2024

hand-dot commented Dec 27, 2023 •

edited

vercel bot commented Dec 27, 2023 •

edited