Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot install from source with latest pip/setuptools, incompatible with Python 3.12 #922

Open
dhdaines opened this issue Nov 15, 2023 · 0 comments

Comments

@dhdaines
Copy link
Contributor

dhdaines commented Nov 15, 2023

Newer versions of pip do not accept arbitrary version strings: pypa/pip#12063

Unfortuately due to the strange automatic versioning done in pdfminer/__init__.py which relies on a github action to give it a real version number, this means that you can no longer install pdfminer.six from the git source without manually editing that file. The error message is too long to post here but trust me, it doesn't work.

Automatically versioning this way seems like a bad idea to me. I know DevOps yadda yadda yadda but not everything has to be a CI/CD action :-)

github-merge-queue bot pushed a commit that referenced this issue Dec 28, 2023
…922) (#923)

* fix(ci): update versions of everything including python

* docs: add changelog entry

* fix(ci): use black from last year

* fix(ci): fix linting and typechecking issues

* docs: put CHANGELOG entries in the right place

* fix(ci): use older pip/setuptools to tolerate bogus -VERSION-

* fix(ci): skip 3.12 for now, fix remaining nox

* chore: ignore

* fix: use setuptools_git_versioning instead of hack

* fix(ci): re-enable python 3.12

* fix(ci): remove version hack from release workflow

* fix(test): ensure path for tools in tests on 3.12

* Update documentation for minimum python version

* Update CHANGELOG.md

* Fix GitHub workflow by removing upper bound on pip and setuptools

* Fix test imports by always importing from root

* Fix import error in test_converter.py

* black

---------

Co-authored-by: Pieter Marsman <pietermarsman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant