Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing test for dumping simple1.pdf and simple3.pdf, because the… #431

Merged
merged 5 commits into from
May 23, 2020

Conversation

pietermarsman
Copy link
Member

@pietermarsman pietermarsman commented May 21, 2020

Pull request

This PR removes the trailer output of the fallback xref from dumppdf.py by default, and add a flag to enable this behavior. In most cases the PDF has one or more valid xrefs and showing those is enough and expected. Showing the fallback xref is only usefull when the PDF does not have an xref.

Fixes #176

How Has This Been Tested?

Ran test, tested on commandline.

Checklist

  • I have added tests that prove my fix is effective or that my feature
    works
  • I have added docstrings to newly created methods and classes
  • I have optimized the code at least one time after creating the initial
    version
  • I have updated the README.md or I am verified that this
    is not necessary
  • I have updated the readthedocs documentation or I
    verified that this is not necessary
  • I have added a consice human-readable description of the change to
    CHANGELOG.md

@wlbentley
Copy link
Contributor

I can only offer a high-level review of the code, but with the flag and the informative Warning message, it looks like it covers all use cases. Big improvement. Thanks.

@pietermarsman pietermarsman merged commit 6e05baf into develop May 23, 2020
@pietermarsman pietermarsman deleted the 176-not-dumping-fallback-xref-by-default branch February 2, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doubled output from dumppdf.py
2 participants