Skip to content

Commit

Permalink
Fix regression introduced in 13e3b37
Browse files Browse the repository at this point in the history
See Debian Bug 888677.
  • Loading branch information
AndreasBilke committed May 23, 2018
1 parent 5c7c9f5 commit 21e4efb
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions src/classes/metadata/pdf.vala
Expand Up @@ -442,10 +442,12 @@ namespace pdfpc.Metadata {
note_text += "\n";
}
note_text += a.get_contents();

// Remove the annotation to avoid its rendering
page.remove_annot(a);

break;
}
// Remove the annotation to avoid its rendering
page.remove_annot(a);
}
if (note_text != "") {
this.notes.set_note(note_text, user_slide, true);
Expand Down

3 comments on commit 21e4efb

@fnevgeny
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Andreas,
Why is this a regression? My intention was indeed to remove all annotations, not only those we recognize & render as comments. This is basically an equivalent of render_for_printing() but without its undesired side effects.

@AndreasBilke
Copy link
Member Author

@AndreasBilke AndreasBilke commented on 21e4efb May 24, 2018 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fnevgeny
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops...

Please sign in to comment.