WIP: New bindings #387
WIP: New bindings #387
Conversation
The new universal actions replace specialized increasePen,decreasePen,increasePointer,decreasePointer,increaseFontSize,decreaseFontSize actions.
rc/pdfpcrc
Outdated
| bind End gotoLast | ||
| bind g goto | ||
|
|
||
| # Bookmarking [the current action names are misleading] |
There was a problem hiding this comment.
Since we are breaking it anyways, why not changing the names?
There was a problem hiding this comment.
Sure, if you agree this is indeed a bookmarking operation (albeit limited to just one bookmark...) I personally use this functionality to reload a presentation if I make changes during rehearsal. But if in future we implement real reload, I see no need for these at all.
There was a problem hiding this comment.
Then we could delete it, but if we make things more consistent now, then this can be changed.
There was a problem hiding this comment.
Actually, it goes a bit deeper, as the "bookmarked" page number is saved in the .pdfpc file under the [last_saved_slide] name. If we also change it there, a minor backward incompatibility will be created. Shall we go for it?
There was a problem hiding this comment.
BTW, on load, if the given slide is an overlay, the last one will be shown. Not sure if this is intended.
There was a problem hiding this comment.
OK, I renamed these actions without touching the function names and code in general.
rc/pdfpcrc
Outdated
| bind m lastSlide | ||
| bind S+m jumpLastSlide | ||
|
|
||
| # History? [these 3 are seriously broken] |
There was a problem hiding this comment.
The nextUnseen/prevSeen pair come from a specific request - #242, but either they're broken, or I don't understand the logic.
About histBack - it works correctly when you press it one time (returns from a goto jump), but then it works randomly. I haven't looked inside yet. The history functionality, if implemented correctly (including forward traversal - S+Space?), might be a nice addition. At least in ordinary pdf viewers I use it quite frequently.
| bind c clearDrawing | ||
| bind d toggleDrawings | ||
|
|
||
| # Pen colors |
There was a problem hiding this comment.
We are loosing all Shift-Number combinations just with switching colors. Do we need all?
There was a problem hiding this comment.
Yes, I thought about it, too. Lately, I use the toolbox to change colors (and I do it infrequently anyway). But probably there are die-hard folks who prefer everything keyboard. Unfortunately, we cannot run a poll among users to get a representative statistics of opinions. Do you have an idea what these combinations could be used for, if we drop their current bindings?
There was a problem hiding this comment.
Sometime ago, there was a discussion about slide bookmarking. This would be a better usage for such combinations. And I agree: changing colors with the toolbox seems more appropriate. I doubt that you are remembering the colors behind the combinations so you have no advantage of that feature.
There was a problem hiding this comment.
Although we both agree changing colors is more convenient using the GUI provided by the toolbox, I cannot exclude some users might have a different opinion. In any case, I believe the action itself - setPenColor - should remain, in particular for interaction through DBus.
No description provided.