Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make constructors of abstract classes protected #446

Merged
merged 1 commit into from Aug 4, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/classes/action/action_mapping.vala
Expand Up @@ -48,7 +48,7 @@ namespace pdfpc {
* methods, and we need blank objects to call them. Thus, this blank
* constructor.
*/
public ActionMapping() {
protected ActionMapping() {
base();
}

Expand Down
2 changes: 1 addition & 1 deletion src/classes/drawings/storage.vala
Expand Up @@ -35,7 +35,7 @@ namespace pdfpc.Drawings.Storage {
*/
protected Metadata.Pdf metadata;

public Base(Metadata.Pdf metadata) {
protected Base(Metadata.Pdf metadata) {
this.metadata = metadata;
}

Expand Down
2 changes: 1 addition & 1 deletion src/classes/renderer/cache/base.vala
Expand Up @@ -37,7 +37,7 @@ namespace pdfpc.Renderer.Cache {
/**
* Initialize the cache store
*/
public Base(Metadata.Pdf metadata) {
protected Base(Metadata.Pdf metadata) {
this.metadata = metadata;
}

Expand Down
2 changes: 1 addition & 1 deletion src/classes/timer_label.vala
Expand Up @@ -95,7 +95,7 @@ namespace pdfpc {
* Default constructor taking the initial time as argument, as well as
* the time to countdown until the talk actually starts.
*/
public TimerLabel(PresentationController controller, time_t start_time = 0) {
protected TimerLabel(PresentationController controller, time_t start_time = 0) {
this.controller = controller;
this.start_time = start_time;
}
Expand Down
2 changes: 1 addition & 1 deletion src/classes/view/behaviour/base.vala
Expand Up @@ -41,7 +41,7 @@ namespace pdfpc.View {
/**
* Base constructor not taking any arguments
*/
public Base() {
protected Base() {
// Nothing to do here
}

Expand Down