no_std support for cotton-ssdp #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preparing to turn mio and tokio into Cargo features.
Cursor, although mostly trivial, depends on the somewhat complex std::io::Error and so is not available in no_std.
Following the suggestions of https://sabrinajewson.org/blog/errors
All features are enabled by default. Currently no-std disables more than it should (engine and message would still make sense in no-std).
The cotton-ssdp "std" tests need cotton-netif "sync". We need the os-poll and net features from mio -- I *really* don't understand how this previously worked.
Because it's not likely to be portable to no_std, as it uses std::time::Instant. An equivalent thing using MonotonicTime would be more appropriate to no_std.
And tidy up a few tests that didn't compile with no_std.
It isn't available in no_std.
Because HashMap isn't in no_std.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NB this PR created retrospectively, for ease of blogging about it...