Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide entire FIPS for states and counties #28

Closed
trashbirdecology opened this issue Jan 6, 2020 · 3 comments
Closed

Provide entire FIPS for states and counties #28

trashbirdecology opened this issue Jan 6, 2020 · 3 comments
Assignees
Labels
enhancement A suggestion or feature that improves existing functionality
Milestone

Comments

@trashbirdecology
Copy link

Great package, thanks!

I request you add one or both of the following:
a) a data object (retrievable via utils::data()) which returns all FIPs info
b) fips_info() and/or fips() returns all FIPS info when blank, or specifying states="all", etc.

Perhaps this feature is buried elsewhere?

@trashbirdecology trashbirdecology added the enhancement A suggestion or feature that improves existing functionality label Jan 6, 2020
@pdil
Copy link
Owner

pdil commented Jan 6, 2020

@trashbirdecology That's a good idea, thanks for the request. I will try to implement both of your suggestions (especially a, so the .csv files can be removed).

If you need this feature urgently, you can do the following in the meantime to get the full FIPS tables:

# states
read.csv(system.file("extdata", "state_fips.csv", package = "usmap"))

# counties
read.csv(system.file("extdata", "county_fips.csv", package = "usmap"))

@pdil pdil added this to the v0.6.0 milestone Jan 6, 2020
@trashbirdecology
Copy link
Author

trashbirdecology commented Jan 6, 2020 via email

@pdil pdil self-assigned this Jan 6, 2020
@pdil
Copy link
Owner

pdil commented Jan 7, 2020

Actually not going to do (a) for now since the csv files are in a different format than what is used in the package, might cause some unforeseen problems but I will revisit it at later time (PR's welcome though 😄).

For now I am implementing the ability to do fips() and fips_info() with no parameters to get the full list/data frame.

@pdil pdil closed this as completed in 12082af Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A suggestion or feature that improves existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants