Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve R CMD Check issues in 0.6.0 #58

Closed
pdil opened this issue Nov 10, 2022 · 0 comments · Fixed by #60
Closed

Resolve R CMD Check issues in 0.6.0 #58

pdil opened this issue Nov 10, 2022 · 0 comments · Fixed by #60
Assignees
@pdil
Labels
bug A bug or issue that should be resolved tech Technical issues and pull requests not directly related to usmap functionality

Comments

@pdil
Copy link
Owner

pdil commented Nov 10, 2022 •
edited

Version 0.6.0 is currently failing several tests on certain platforms: https://cran.r-project.org/web/checks/check_results_usmap.html

Example:

Version: 0.6.0 
Check: tests 
Result: ERROR 
     Running 'testthat.R' [10s/14s]
    Running the tests in 'tests/testthat.R' failed.
    Complete output:
     > library(testthat)
     > library(usmap)
     > 
     > test_check("usmap")
     [ FAIL 2 | WARN 3 | SKIP 0 | PASS 163 ]
     
     == Failed tests ================================================================
     -- Failure ('test-plot.R:138'): singular regions can be used -------------------
     plot_usmap(regions = "states")$layers not equal to plot_usmap(regions = "state")$layers.
     Component 1: Component 12: Component 5: Component 21: Component 11: 1 string mismatch
     Component 1: Component 12: Component 5: Component 21: Component 12: 1 string mismatch
     Component 2: Component 12: Component 5: Component 21: Component 11: 1 string mismatch
     Component 2: Component 12: Component 5: Component 21: Component 12: 1 string mismatch
     -- Failure ('test-plot.R:140'): singular regions can be used -------------------
     plot_usmap(regions = "counties")$layers not equal to plot_usmap(regions = "county")$layers.
     Component 1: Component 12: Component 5: Component 21: Component 11: 1 string mismatch
     Component 1: Component 12: Component 5: Component 21: Component 12: 1 string mismatch
     Component 2: Component 12: Component 5: Component 21: Component 11: 1 string mismatch
     Component 2: Component 12: Component 5: Component 21: Component 12: 1 string mismatch
     
     [ FAIL 2 | WARN 3 | SKIP 0 | PASS 163 ]
     Error: Test failures
     Execution halted 
Flavor: [r-devel-linux-x86_64-debian-clang](https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-debian-clang/usmap-00check.html)

This must be fixed by November 21, 2022 or package will be removed from CRAN. Fix will be included in version 0.6.1.
@pdil pdil added the bug A bug or issue that should be resolved label Nov 10, 2022
@pdil pdil self-assigned this Nov 10, 2022
@pdil pdil mentioned this issue Nov 12, 2022
Merged
@pdil pdil closed this as completed in #60 Nov 12, 2022
@pdil pdil added the tech Technical issues and pull requests not directly related to usmap functionality label Nov 12, 2022
pdil added a commit to pdil/usmapdata that referenced this issue Dec 11, 2023
@pdil
Add function to load FIPS data (#3)
9391988 
* Added `fips_data` function to load FIPS data from included csv files
* Provides cleaner way to load FIPS data in `usmap` package without
loading `extdata` file

See
[pdil/usmap#58](pdil/usmap#72 (comment))
pdil added a commit to pdil/usmapdata that referenced this issue Dec 27, 2023
@pdil
Add function to load FIPS data (#3)
5d78dd9 
* Added `fips_data` function to load FIPS data from included csv files
* Provides cleaner way to load FIPS data in `usmap` package without
loading `extdata` file

See
[pdil/usmap#58](pdil/usmap#72 (comment))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pdil pdil

Labels
bug A bug or issue that should be resolved tech Technical issues and pull requests not directly related to usmap functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolve failing R CMD check in 0.6.0 pdil/usmap
1 participant
@pdil