Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add snapshot testing for plots #80

Closed
pdil opened this issue Jan 15, 2024 · 0 comments · Fixed by #82
Closed

Add snapshot testing for plots #80

pdil opened this issue Jan 15, 2024 · 0 comments · Fixed by #82
Assignees
@pdil
Labels
tech Technical issues and pull requests not directly related to usmap functionality
Milestone
v0.7.0

Comments

@pdil
Copy link
Owner

pdil commented Jan 15, 2024

The test suite should include snapshot tests for map plots to ensure any changes to the mapping data or functions continue to produce the expected plots.

The best candidate for how these should be implemented is the vdiffr package which is also used by ggplot2.
@pdil pdil added the tech Technical issues and pull requests not directly related to usmap functionality label Jan 15, 2024
@pdil pdil added this to the v0.7.0 milestone Jan 15, 2024
@pdil pdil self-assigned this Jan 15, 2024
@pdil pdil mentioned this issue Jan 17, 2024
Merged
@pdil pdil closed this as completed in #82 Jan 17, 2024
pdil added a commit that referenced this issue Jan 17, 2024
@pdil
Add visual snapshot tests (#82)
01f7420 
* Added `vdiffr`-based tests for `plot_usmap()`
* Renamed `rivers` data set to `usrivers` to avoid clash with
`datasets::rivers` package
* Fixed missing `citypop.xlsx` file and rebuilt all data sets

resolves #80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pdil pdil

Labels
tech Technical issues and pull requests not directly related to usmap functionality
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging a pull request may close this issue.

Add visual snapshot tests pdil/usmap
1 participant
@pdil