Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation and theme based on recent ggplot2 updates #90

Merged
merged 4 commits into from
Mar 7, 2024
Merged

Update documentation and theme based on recent ggplot2 updates #90

merged 4 commits into from
Mar 7, 2024

Conversation

pdil
Copy link
Owner

@pdil pdil commented Mar 2, 2024 •
edited

  • size was erroneously left in the documentation after the ggplot2 3.4.0 update.
    • It has been replaced with linewidth.
  • Fix legend in theme after the ggplot2 v3.5.0
  • Update tests to use 3rd edition of testthat

fixes #89

@pdil pdil added the documentation Improvements or additions to documentation label Mar 2, 2024
@pdil pdil self-assigned this Mar 2, 2024
@pdil pdil added the tech Technical issues and pull requests not directly related to usmap functionality label Mar 7, 2024
@pdil pdil changed the title Fix size in plot_usmap() documentation Update documentation and theme based on recent ggplot2 updates Mar 7, 2024
@pdil pdil merged commit f5c81cc into master Mar 7, 2024
8 checks passed
@pdil pdil deleted the bugfix/change-size-to-linewidth branch March 7, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pdil pdil

Labels
documentation Improvements or additions to documentation tech Technical issues and pull requests not directly related to usmap functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

size parameter not working
1 participant
@pdil