Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving test_download_packages test #3

Open
itayporezky opened this issue Jan 30, 2024 · 1 comment
Open

Improving test_download_packages test #3

itayporezky opened this issue Jan 30, 2024 · 1 comment

Comments

@itayporezky
Copy link

(FYI, Junior)
I would like to attempt to contribute to this,

Would it be a smart idea to add checksum verification to: (

def test_download_packages(pdm, tmp_path, lockfile_options):
) of downloaded files vs the checksum pdm.static.lock found at file?

If so, would this be a seperate test or should i extend the existing test?

@frostming
Copy link
Contributor

Yes, please do it, you can just extend the test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants